Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extend intro and add summary of version history #72

Closed
wants to merge 1 commit into from
Closed

extend intro and add summary of version history #72

wants to merge 1 commit into from

Conversation

dericed
Copy link
Contributor

@dericed dericed commented Jun 8, 2017

No description provided.

@ablwr
Copy link
Contributor

ablwr commented Jun 8, 2017

👍

michaelni
michaelni reviewed Jun 10, 2017
View reviewed changes
rfc_frontmatter.md Outdated
<front>
<title>Commit to mark FFV1 version 3 as non-experimental</title>
<author initials="L." surname="Barbato" fullname="Luca Barbato"/>
<date month="June" year="2016" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect, in fact all of the 1.3 entry
1.3 was made non experimental in 2013 by me
commit abe76b851c05eea8743f6c899cbe5f7409b0f301
Author: Michael Niedermayer michaelni@gmx.at
Date: Sat Aug 17 04:28:53 2013 +0200

ffv1enc: Make ffv1.3 non experimental

@dericed
Copy link
Contributor Author

dericed commented Jun 10, 2017

ooops. Updated to correct info via #72 (comment). Please re-review.

@dericed
Copy link
Contributor Author

dericed commented Jun 16, 2017

ping. any other changes suggested?

@retokromer
Copy link
Contributor

LGTM

@michaelni
Copy link
Member

build seems to fail here: (seems a simple typo, ill fix and push)

Parsing file draft-ietf-cellar-ffv1-02.xml
WARNING: Parsing Error: error parsing attribute name, line 1533, column 1
ERROR: Unable to parse the XML document: draft-ietf-cellar-ffv1-02.xml
draft-ietf-cellar-ffv1-02.xml: Line 1533: error parsing attribute name
draft-ietf-cellar-ffv1-02.xml: Line 1533: attributes construct error
draft-ietf-cellar-ffv1-02.xml: Line 1533: Couldn't find end of Start Tag author
draft-ietf-cellar-ffv1-02.xml: Line 1533: error parsing attribute name
draft-ietf-cellar-ffv1-02.xml: Line 1533: attributes construct error
draft-ietf-cellar-ffv1-02.xml: Line 1533: Couldn't find end of Start Tag author line 1532
make: *** [draft-ietf-cellar-ffv1-02.html] Error 1

@michaelni michaelni closed this in 330ccde Jun 17, 2017
@JeromeMartinez JeromeMartinez deleted the expand-intro branch June 23, 2020 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelni michaelni michaelni left review comments

@JeromeMartinez JeromeMartinez JeromeMartinez approved these changes

@retokromer retokromer retokromer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dericed @ablwr @retokromer @michaelni @JeromeMartinez