Implement no-copy subarray iteration (Implements #3386) #4584
Conversation
| # ```text | ||
| # b -- c -- d -- | ||
| # ``` | ||
| def each(*, within range : Range(Int, Int)) |
There was a problem hiding this comment.
I don't really like requiring within:. Even the example doesn't have it, so it's broken as far as I see 😛
There was a problem hiding this comment.
Thank you for checking, the example is broken. The start/count overload also use required named-arguments, I think (for consistency) changing the example should be enough
|
LGTM |
|
@cjgajard this looks good 👍 Are you around to fix the minor issues? |
|
They should at least be forced for start and count, and I don't mind the range being a forced named parameter too. I like the named params |
|
@RX14 A better question is why count is mandatory. Default could be to iterate to end. |
|
You could make it default to |
| # 2 -- 3 -- | ||
| # ``` | ||
| def each_index(*, start : Int, count : Int) | ||
| raise ArgumentError.new "negative count: #{count}" if count < 0 |
There was a problem hiding this comment.
Oops, Title cased Exception messages, please.
…rystal-lang#4584) * Implement no-copy subarray iteration * Fix example for Indexable#each(*, within) * Fix Indexable#each_index(*, start, count) example
Since I deleted my previous fork I need to PR again.
This PR closes #3390.