MapgenFlatParams::MapgenFlatParams()
 {
-	spflags          = 0;
-	ground_level     = 8;
-	large_cave_depth = -33;
-	cave_width       = 0.09;
-	lake_threshold   = -0.45;
-	lake_steepness   = 48.0;
-	hill_threshold   = 0.45;
-	hill_steepness   = 64.0;

@nerzhul this is a bit of a shock, how do i decide whether a parameter can remain here or not? Why do the noise parameters remain here?

@paramat look at the header file directly

-	u32 spflags;
-	s16 ground_level;
-	s16 large_cave_depth;
-	float cave_width;
-	float lake_threshold;
-	float lake_steepness;
-	float hill_threshold;
-	float hill_steepness;
+	u32 spflags = 0;
+	s16 ground_level = 8;
+	s16 large_cave_depth = -33;
+	float cave_width = 0.09f;
+	float lake_threshold = -0.45f;
+	float lake_steepness = 48.0f;
+	float hill_threshold = 0.45f;
+	float hill_steepness = 64.0f;

in C++11 all trivial types defaults should be defined with membler declaration. You can do that for noise params too if needed, i just moved trivial types.

Ok thanks.

@nerzhul i find it very useful when workng on the 7 mapgens to have all mapgen parameters in one place and just above the parameter getters and setters in the .cpp file, please can i move these simple parameters back to the .cpp file?

I don't mind simple parameters being moved anywhere else in the code, just in the files of the 7 core mapgens.

I considered moving the noise parameters to the .h file but the addition of 'NoiseParams' to each line will make the lines excessively long and they will become less unreadable (for me) if i split the lines.

Not sure i can be bothered to move them again, i'll try to get used to it first :]