vivaldi: 1.9.818.44-1 -> 1.10.867.38-1 #26694
Merged
+17
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@romildo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @otwieracz, @NeQuissimus and @volth to be potential reviewers. |
I have asked on IRC and someone expressed the opinion that freezing a web browser engine sounds risky security-wise, and I agree. Vivaldi is evolving quickly and soon version 1.9 would be lacking too much from upstream. I do not think it should be kept in nixpkgs. |
- Update to version 1.10.867.38-1 - Drop i386 arch. Vivaldi has suspended support for Linux 32-bit for Vivaldi 1.10. Unfortunately, this is due to Chromium suspending support for it and maintaining it themselves would take too much resources. See https://forum.vivaldi.net/post/142489. - Update dependency on gtk2 to gtk3. - Move dependency patchelf from buildInputs to nativeBuildInputs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)