libreoffice: fix #25831 #26670
Merged
libreoffice: fix #25831 #26670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to Linus Heckemann <git@sphalerite.org> for creating the patch.
|
@lverns, thanks for your PR! By analyzing the history of the files in this pull request, we identified @7c6f434c, @domenkozar and @urkud to be potential reviewers. |
|
Thanks for this, I was going to do it but the prospect of having to wait for libreoffice to build in order to test it scared me off :p |
|
No problem. Thanks for the patch. And yes, the build times are crazy. A little under 15 hours on my laptop. (And then double that since I had to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Closes #25831.
Allows users to click on links in LibreOffice and have them opened in their default browser. Also allows them to use the
File > Send > ...menu to send documents with their default mail program.I really think this is an upstream bug and have reported it.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"spadmin, but this is not a regression.