If clone fails (which it won't - IAtomContainer should not have decla…

…red the exception thrown) then trail is null.. and we'll have NPE within the mutate(trial) call. This is better handled with an IllegalStateException.
cdk · May 16, 2017 · d56977d · d56977d
1 parent 02f82da
commit d56977d
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/tool/structgen/src/main/java/org/openscience/cdk/structgen/RandomGenerator.java b/tool/structgen/src/main/java/org/openscience/cdk/structgen/RandomGenerator.java
@@ -73,10 +73,9 @@ public IAtomContainer proposeStructure() {
         logger.debug("RandomGenerator->proposeStructure() Start");
         do {
             try {
-                trial = (IAtomContainer) molecule.clone();
+                trial = molecule.clone();
             } catch (CloneNotSupportedException e) {
-                logger.error("Could not clone IAtomContainer!" + e.getMessage());
-                trial = null;
+                throw new IllegalStateException("Could not clone IAtomContainer!" + e.getMessage());
             }
             mutate(trial);
             if (logger.isDebugEnabled()) {