crashplan: refactor allowing local version bumping with overrideAttrs #26666
+2
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was not possible to increment the version of crashplan locally using overrideAttrs due to the hardcoded version in the installPhase. Now a user can modify the `src` and `name` values to increment the version manually in there configuration using overrideAttrs.
|
@ajevans85, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jerith666, @sztupi and @domenkozar to be potential reviewers. |
|
Seems simpler to do this by abandoning the |
|
Yes that works. A user can override the |
7 tasks
|
Okay, I opened #26705 for my change then. @ajevans85, are you planning to open a PR for the 4.8.2 -> 4.8.3 update, or shall I? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
It was not possible to increment the version of crashplan locally using overrideAttrs due to the hardcoded version in the installPhase.
Now a user can modify the
srcandnamevalues to increment the version manually in their configuration using overrideAttrs.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)cc @sztupi @domenkozar @jerith666