Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor macro interpreter "identify". tr("c", "x") is always slower than gsubs. #4586

Closed
wants to merge 1 commit into from
Closed

Minor macro interpreter "identify". tr("c", "x") is always slower than gsubs. #4586

wants to merge 1 commit into from

Conversation

akzhan
Copy link
Contributor

@akzhan akzhan commented Jun 18, 2017 

  tr single char string   4.38M (228.22ns) (± 1.14%)  1.50× slower
       gsub single char    5.0M (200.19ns) (± 2.18%)  1.31× slower
gsub single char string   6.56M (152.52ns) (± 4.08%)       fastest

String.gsub("c", "x") faster in all cases (nonexistent character to replace etc.).

@akzhan
Minor update of macro interpreter "identify". tr("c", "x") is always …
4ae59d5 
…slower than gsubs.

  tr single char string   4.38M (228.22ns) (± 1.14%)  1.50× slower
       gsub single char    5.0M (200.19ns) (± 2.18%)  1.31× slower
gsub single char string   6.56M (152.52ns) (± 4.08%)       fastest
@asterite
Copy link
Member

I think it's better to optimize tr for this case then.

@akzhan akzhan mentioned this pull request Jun 30, 2017
Closed
@asterite asterite mentioned this pull request Sep 15, 2017
Merged
@akzhan akzhan deleted the minor-macro-update-single-char-tr-slower-than-gsubs branch September 17, 2017 14:57
@asterite asterite added this to the Next milestone Sep 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
performance topic:stdlib
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@akzhan @asterite