Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodePackages.javascript-typescript-langserver: init at 2.0.0 #26672

Merged
merged 1 commit into from
Jun 18, 2017
Merged

nodePackages.javascript-typescript-langserver: init at 2.0.0 #26672

merged 1 commit into from
Jun 18, 2017

Conversation

dywedir
Copy link
Member

@dywedir dywedir commented Jun 17, 2017

Motivation for this change

Add javascript-typescript-langserver

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@mention-bot
Copy link

@dywedir, thanks for your PR! By analyzing the history of the files in this pull request, we identified @svanderburg, @Mic92 and @Ma27 to be potential reviewers.

@Mic92 Mic92 merged commit 502ca4a into NixOS:master Jun 18, 2017
@Mic92
Copy link
Member

Mic92 commented Jun 18, 2017

Thanks!

@dywedir dywedir deleted the javascript-typescript-langserver branch June 18, 2017 07:31
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants