gnutls: Fix broken darwin build #26678
Closed
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jbaum98, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fpletz, @vcunat and @wkennington to be potential reviewers. |
|
The changes look ok, but it builds fine without as far as I can tell http://hydra.nixos.org/build/54541669. |
|
Hmm. It won't build for me without it. I'm on OSC 10.12.5. |
|
That fix has been tried already but causes crashes (reportedly). Please see discussion on d6454e6a1. /cc @copumpkin. |
|
I haven't experienced any crashes. So what's recommended for getting it to work on darwin? |
0xABAB
approved these changes
Jul 1, 2017
|
No longer happening in Hydra: https://hydra.nixos.org/job/nixpkgs/trunk/gnutls.x86_64-darwin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
gnutlswasn't building on darwin. This stoppedemacsfrom building as well.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)