Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add llvm operand bundle def and catch pad/ret/switch #4501

Merged
merged 3 commits into from Jun 23, 2017

Conversation

bcardiff
Copy link
Member

@bcardiff bcardiff commented Jun 3, 2017

In order to use emit catch pads for exception handling these functions will be needed.
For call and invokes a funclet operand bundle def is needed. Current C api does not allow to specify one. The default LLVM::OperandBundleDef.null make the change backward compatible.

This is needed to generate begin/rescue blocks with windows SEH.

@bcardiff bcardiff added this to Issues in Windows Jun 3, 2017
@bcardiff
Copy link
Member Author

This will conflict with #4396, but I think we should ensure to have this before #4396 in master.

Any input before merging this @ysbaddaden / @waj ?

@ysbaddaden
Copy link
Contributor

It's fine. Dropping LLVM 3.5 / 3.5 support can be redone anytime. It's only cutting lines, after all :-)

@bcardiff bcardiff merged commit 72fe026 into crystal-lang:master Jun 23, 2017
@bcardiff bcardiff added this to the Next milestone Jun 23, 2017
bcardiff pushed a commit that referenced this pull request Jun 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Windows
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants