Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wpsoffice: cleanup and i686 version #26343

Merged
merged 1 commit into from Jun 10, 2017
Merged

wpsoffice: cleanup and i686 version #26343

merged 1 commit into from Jun 10, 2017
+46 −23

Conversation

ghost
Copy link

@ghost ghost commented Jun 3, 2017

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@mention-bot
Copy link

@gnidorah, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dguibert, @pallavagarwal07 and @fpletz to be potential reviewers.

@Mic92
Copy link
Member

Mic92 commented Jun 3, 2017

fails to build because of an not allowed reference to the build directory. @ttuegel might have more insights how to fix this.

...
installing                                                                                                                                                                                    
post-installation fixup                                                                                                                                                                       
stripping (with flags -S) in /nix/store/06pkl9cb8wf2qr61lsbgpg5aqpkax7fn-wpsoffice-10.1.0.5672/bin                                                                                            
patching script interpreter paths in /nix/store/06pkl9cb8wf2qr61lsbgpg5aqpkax7fn-wpsoffice-10.1.0.5672                                                                                        
/nix/store/06pkl9cb8wf2qr61lsbgpg5aqpkax7fn-wpsoffice-10.1.0.5672/opt/kingsoft/wps-office/wpp: interpreter directive changed from "/bin/bash" to "/nix/store/wb34dgkpmnssjkq7yj4qbjqxpnapq0lw-bash-4.4-p12/bin/bash"                                                                                                                                                                         
/nix/store/06pkl9cb8wf2qr61lsbgpg5aqpkax7fn-wpsoffice-10.1.0.5672/opt/kingsoft/wps-office/install_fonts: interpreter directive changed from "/bin/bash" to "/nix/store/wb34dgkpmnssjkq7yj4qbjqxpnapq0lw-bash-4.4-p12/bin/bash"                                                                                                                                                               
/nix/store/06pkl9cb8wf2qr61lsbgpg5aqpkax7fn-wpsoffice-10.1.0.5672/opt/kingsoft/wps-office/wps: interpreter directive changed from "/bin/bash" to "/nix/store/wb34dgkpmnssjkq7yj4qbjqxpnapq0lw-bash-4.4-p12/bin/bash"                                                                                                                                                                         
head: write error: Broken pipe                                                                                                                                                                
/nix/store/06pkl9cb8wf2qr61lsbgpg5aqpkax7fn-wpsoffice-10.1.0.5672/opt/kingsoft/wps-office/et: interpreter directive changed from "/bin/bash" to "/nix/store/wb34dgkpmnssjkq7yj4qbjqxpnapq0lw-bash-4.4-p12/bin/bash"                                                                                                                                                                          
/nix/store/06pkl9cb8wf2qr61lsbgpg5aqpkax7fn-wpsoffice-10.1.0.5672/bin/wpp: interpreter directive changed from "/bin/bash" to "/nix/store/wb34dgkpmnssjkq7yj4qbjqxpnapq0lw-bash-4.4-p12/bin/bash"                                                                                                                                                                                             
/nix/store/06pkl9cb8wf2qr61lsbgpg5aqpkax7fn-wpsoffice-10.1.0.5672/bin/et: interpreter directive changed from "/bin/bash" to "/nix/store/wb34dgkpmnssjkq7yj4qbjqxpnapq0lw-bash-4.4-p12/bin/bash"
/nix/store/06pkl9cb8wf2qr61lsbgpg5aqpkax7fn-wpsoffice-10.1.0.5672/bin/wps: interpreter directive changed from "/bin/bash" to "/nix/store/wb34dgkpmnssjkq7yj4qbjqxpnapq0lw-bash-4.4-p12/bin/bash"                                                                                                                                                                                             
checking for references to /build in /nix/store/06pkl9cb8wf2qr61lsbgpg5aqpkax7fn-wpsoffice-10.1.0.5672...                                                                                     
RPATH of binary /nix/store/06pkl9cb8wf2qr61lsbgpg5aqpkax7fn-wpsoffice-10.1.0.5672/opt/kingsoft/wps-office/office6/libphonon.so.4.4.0 contains a forbidden reference to /build                 
                                                                                                                                                                                              
builder for ‘/nix/store/48likrg03x7794c5wkn6lmqvqngab99w-wpsoffice-10.1.0.5672.drv’ failed with exit code 1                                                                                   
error: build of ‘/nix/store/48likrg03x7794c5wkn6lmqvqngab99w-wpsoffice-10.1.0.5672.drv’ failed

@ttuegel
Copy link
Member

ttuegel commented Jun 3, 2017

You need to remove the build directory before the call to patchelf.

@ghost
Copy link
Author

ghost commented Jun 4, 2017

@Mic92 @ttuegel Just this? Thanks

@Mic92 Mic92 merged commit f80d786 into NixOS:master Jun 10, 2017
@Mic92
Copy link
Member

Mic92 commented Jun 10, 2017

Thanks!

@ghost
Copy link
Author

ghost commented Jun 12, 2017

@Mic92 Thank you!

@ghost ghost deleted the master4 branch June 12, 2017 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mention-bot @Mic92 @ttuegel