Add limits to HTTP request parsing #4428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhass
approved these changes
May 19, 2017
|
Any benchmarks before and after? Reason: Changes to http request parsing touch a lot of users, so we need any benchmark tool/results for it. |
|
Before After Running the benchmark multiple times, it doesn't seem that there's any noticeable difference (the results are quite variable) |
|
Thanks, @RX14 . Will glad to see automation on it :) |
|
Thanks @RX14 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1043.
A lot of servers simply use a 8KiB limit to the whole header, but it's easier not to here. We use larger limits than most servers, so we should be safe.