proofgeneral_HEAD: fix #25905
Merged
proofgeneral_HEAD: fix #25905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Ptival, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vbgl, @spacekitteh and @jwiegley to be potential reviewers. |
|
@spacekitteh did you not run into this issue with |
|
This PR broke the default |
|
@gebner woops, that was a bad oversight on my part! I think we should probably keep the 4.4 around, in case HEAD ever breaks, it's good to have a more stable fallback no? At least for now, let's revert the patch deletion. Should I:
|
I think that's the way to go here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
As far as I can tell, the current derivation in master is broken, because of those changes:
ProofGeneral/PG@1a18e33
ProofGeneral/PG#177
It seems we don't need a patch anymore as a result.