timelapse-deflicker: init at 142acd1 #25904
Merged
+48
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
May 20, 2017
| description = "Simple script to deflicker images taken for timelapses"; | ||
| homepage = https://github.com/cyberang3l/timelapse-deflicker; | ||
| license = licenses.gpl3; | ||
| platforms = platforms.unix; |
There was a problem hiding this comment.
Do you want to maintain this package?
There was a problem hiding this comment.
Yes :)
What's the syntax for that? maintainers = [ "Valérian Galliat <val@codejam.info>" ];? Or should I add myself to lib/maintainers.nix?
There was a problem hiding this comment.
Cool, I updated the PR. I assume the maintainer key must match my username on GitHub?
|
Thanks for the nitpicks commit @Mic92, didn't know about most of that stuff, it's so much cleaner like that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a package for timelapse-deflicker.
Tested on macOS and NixOS.
The
ClassMethodMakerPerl library is not a dependency of timelapse-deflicker but it's needed byTermProgressBar. But even though it's in itspropagatedBuildInputs, I had an error running the program on howClassMethodwas not found, and addingClassMethodMakerto the direct dependencies fixed it. Any idea what I'm doing wrong?