Skip to content

firefox, firefox-bin: 53.0.3 -> 54.0, firefox-esr: 52.1.2esr -> 52.2.0esr [Critical security fix] #26571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 15, 2017
Merged

firefox, firefox-bin: 53.0.3 -> 54.0, firefox-esr: 52.1.2esr -> 52.2.0esr [Critical security fix] #26571

merged 5 commits into from
Jun 15, 2017
+392 −417

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Jun 14, 2017

Motivation for this change
  • Various security fixes
  • Simplified the download button and download status panel
  • Added support for multiple content processes (e10s-multi)
  • Added Burmese (my) locale

https://www.mozilla.org/en-US/firefox/54.0/releasenotes/

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Played a video on YouTube with firefox, firefox-esr, and firefox-bin.

Sorry, something went wrong.

@joachifm
Copy link
Contributor

I wonder about the rebuild impact of at nss/nspr; can those go directly to master?

@vcunat
Copy link
Member

vcunat commented Jun 15, 2017 

Estimating rebuild amount by counting changed Hydra jobs.
    210 x86_64-darwin
   1549 x86_64-linux

(this whole PR)

@vcunat
Copy link
Member

vcunat commented Jun 15, 2017

I believe the rebuild amount is OK, esp. given the security fixes.

vcunat
vcunat approved these changes Jun 15, 2017
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to run OK.

@vcunat vcunat added the 9.needs: port to stable A PR needs a backport to the stable release. label Jun 15, 2017
@vcunat vcunat merged commit 930a00b into NixOS:master Jun 15, 2017
vcunat added a commit that referenced this pull request Jun 15, 2017
@vcunat
Merge #26571: firefox* updates (critical security)
952bb9a
@vcunat vcunat mentioned this pull request Jun 15, 2017
Closed
7 tasks
@vcunat vcunat self-assigned this Jun 16, 2017
vcunat added a commit that referenced this pull request Jun 16, 2017
@vcunat
Merge #26571: firefox* updates (critical security)
d33c4b2 
(cherry picked from commit 952bb9a)
Yes, finally I could do this simple cherry-pick :-)
@vcunat vcunat removed the 9.needs: port to stable A PR needs a backport to the stable release. label Jun 16, 2017
ambrop72 pushed a commit to ambrop72/nixpkgs that referenced this pull request Jun 21, 2017
@vcunat @ambrop72
Merge NixOS#26571: firefox* updates (critical security)
7248d1a 
(cherry picked from commit 952bb9a)
Yes, finally I could do this simple cherry-pick :-)
adrianpk added a commit to adrianpk/nixpkgs that referenced this pull request May 31, 2024
@adrianpk
Merge NixOS#26571: firefox* updates (critical security)
808fc04 
(cherry picked from commit 952bb9a)
Yes, finally I could do this simple cherry-pick :-)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat

Assignees

@vcunat vcunat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@taku0 @joachifm @vcunat