Skip to content

cmdliner: 0.9.8 -> 1.0.0, ocp-indent: 1.5.2 -> 1.6.0 #26195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2017
Merged

cmdliner: 0.9.8 -> 1.0.0, ocp-indent: 1.5.2 -> 1.6.0 #26195

merged 2 commits into from
May 28, 2017

Conversation

romildo
Copy link
Contributor

@romildo romildo commented May 28, 2017

Motivation for this change

Update to new versions.

cmdliner changes

ocp-indent changes

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

romildo added 2 commits May 28, 2017 17:38

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@mention-bot
Copy link

@romildo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vbgl, @aske and @nbp to be potential reviewers.

@Mic92 Mic92 merged commit 868529b into NixOS:master May 28, 2017
@romildo romildo deleted the upd.ocp-indent branch May 29, 2017 01:13
@romildo
Copy link
Contributor Author

romildo commented May 30, 2017

This fixes #25339.

@vbgl
Copy link
Contributor

vbgl commented May 31, 2017

This breaks bap. Please revert.

We should keep the old version as long as other packages depend on it. The two versions can live side by side under different attribute paths.

@romildo
Copy link
Contributor Author

romildo commented May 31, 2017

Which version should be the default: cmdliner-0.9.8 or cmdliner-1.0.0?

I have prepared a fix where the old cmdliner-0.9.8 is the default, and ocp-indent depends explicitly on cmdliner-1.0.0.

Refer to PR #26286.

cc @vbgl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants