Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .travis.yml for continuous integration. #181

Merged
merged 4 commits into from Jun 1, 2017

Conversation

paramsingh
Copy link
Collaborator

@paramsingh paramsingh commented May 28, 2017

Would just need to enable travis for this repo on https://travis-ci.org/metabrainz after this, and it should run tests on all pull requests then.

I didn't run test.sh and integration-test.sh directly in travis.yml because they always return 0 in the end.

Example build: https://travis-ci.org/paramsingh/listenbrainz-server/builds/236926159

@paramsingh
Copy link
Collaborator Author

Gonna have to fix this to use init_influx now.

@paramsingh
Copy link
Collaborator Author

One test seems to be failing, I'm gonna close this for a while and check what the problem is.

@paramsingh paramsingh closed this May 31, 2017
@paramsingh
Copy link
Collaborator Author

paramsingh commented May 31, 2017

Seemed like the test was failing because influx-writer wasn't up before the first test ran. Adding a sleep before running the tests and after bringing up the containers seems to have fixed it.

Passing build: https://travis-ci.org/paramsingh/listenbrainz-server/builds/238000061

@paramsingh paramsingh reopened this May 31, 2017
Copy link
Member

@mayhem mayhem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know travis at all, but in the interest of trying this, let's go!

@mayhem mayhem merged commit 4598cd1 into metabrainz:master Jun 1, 2017
@paramsingh paramsingh deleted the travis branch June 20, 2017 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants