New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add part upgrade for engine configs proof of concept #1654
Conversation
Hope it works.
Note that it is currently targeted for a TestFlight config but you can move the *@PARTUPGRADE line to the appropriate CONFIG block in the engine configger rather than in the testflight patches section (some engines may not have testflight configs yet). I.e. |
@NathanKell First, MM did not like the syntax for this code:
The place that we keep running into problems is with this area:
I know that this is the whole point of this attempt is to only show if the different configs are loaded. From what I can tell from the log, what is happening is that the PARTUPGRADE is correctly running, and then immediately being deleted by this set of code. I attempted to modify if to this to get it to run later:
However, that seems to not accomplish what we are going for. What we need to have happen is to have that run after all of the configs have been analyzed and determined to exist, and then the deleteme will change over to 0 and should work. Any ideas? |
This should be OK now. I dunno why MM didn't like that syntax; it's crucial to making this work, and on my end it did like it. So I'm confused. Anyway I tested this in a standalone KSP install with just MM using this cfg and it created the correct confignodes in configcache. The syntax is crucial because it needs to only decrement deleteme if an engine config is applied. Well, technically we're doing it when the TF config is applied, for clarity, but eh, you could put that line in the CONFIG above if you like. The idea is every time the engine configs are applied, then and only then is deleteme decremented (to show that the config is in use), and at the end of the day any partupgrades with deleteme >0 (i.e. never touched) are deleted. |
@pap1723 This stuff is all on the new branch, right? I should close this? |
Correct
…On Jun 18, 2017 2:58 AM, "NathanKell" ***@***.***> wrote:
@pap1723 <https://github.com/pap1723> This stuff is all on the new
branch, right? I should close this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1654 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ASjbfyVxMhO8vffJ6OCSCs5CZQsFfcg-ks5sFNi4gaJpZM4NohuI>
.
|
This is completed |
Hope it works.