Galaxis: init at 1.9 #26185
Merged
Galaxis: init at 1.9 #26185
+49
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pSub
approved these changes
May 28, 2017
pkgs/games/galaxis/default.nix
Outdated
| sha256 = "1dsypk5brfbc399pg4fk9myyh5yyln0ljl1aiqkypws8h4nsdphl"; | ||
| }; | ||
|
|
||
| buildInputs = |
There was a problem hiding this comment.
Nitpick: Why is there a extra newline? IMO it does not improve readability.
|
@Mic92 I'm curious: I suppose you don't have push access to @AndersonTorres fork, so how did you add commits to this PR? |
|
This is a recent feature of github. When you open a pull request, maintainers have write access to the branch by default, except if contributors untick "Allow edits from maintainers". |
|
Ah, good to know. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
New package
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)