python: django-compat & django-hijack tests (also bump django-hijack) #26166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @risicle . Could you keep in the comment I added? I think it is going to be relevant again at some point and I really don't want people to add overrides within the package set. |
|
Sure. I'll put it in the toplevel |
risicle
force-pushed
the
django-compat-hijack-tests
branch
from
a4ea2e7
to
17273a4
Compare
|
Oh actually hold off on merging this would you, just want to check one more thing... |
|
Yeah sorry, this is actually running the tests against the code in the source directory, not the installed package. I'll have to fix this. |
also add self as maintainer
also fix & enable tests, add self as maintainer
risicle
force-pushed
the
django-compat-hijack-tests
branch
from
17273a4
to
fa44b72
Compare
|
Ok should be good to go - knock yourself out. |
FRidh
approved these changes
May 29, 2017
|
Hi, Sorry for late reply, I was away some day and still have some work to catch up ^_^ Looks good to me, and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Ah - seems we were both tinkering with this one at the same time.
Both
django-compatanddjango-hijack's (same author) tests are run using a customruntests.pyscript, which isn't included in the sdist packages on pypi. So I fixed the two packages by pulling the source from github tags instead and included a customcheckPhase.While I was at it I also bumped
django-hijackto the latest version and split it into a separate file.I'm not totally sure as to the origin of
django-hijack's django 1.9 requirement, but, well, the tests sure as hell pass with django 1.11.1. So I'm assuming it's safe to disregard that problem as ancient history...?Added self as maintainer as I think I (or one of my old colleagues) added these packages in the first place.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)