Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove enum.cr TODO due to 0.22 released #4477

Merged
merged 1 commit into from May 30, 2017
Merged

Remove enum.cr TODO due to 0.22 released #4477

merged 1 commit into from May 30, 2017

Conversation

makenowjust
Copy link
Contributor

It is no longer needed. In fact, make std_spec is green without this TODO.

@makenowjust
Copy link
Contributor Author

Hmm, crystal on CI is not latest version...?

@bcardiff
Copy link
Member

It seems the docker images are outdated :-(.

@jhass would you trigger a rebuild for 0.22.0?

@bcardiff
Copy link
Member

@makenowjust we are on hold due to some CI issues, once that is solved we will merge this.

@jhass
Copy link
Member

jhass commented May 30, 2017

Travis passed now :)

@bcardiff bcardiff merged commit a8b9336 into crystal-lang:master May 30, 2017
@bcardiff bcardiff added this to the Next milestone May 30, 2017
@bcardiff
Copy link
Member

Thanks @makenowjust and @jhass

@makenowjust makenowjust deleted the fix/enum/rm-todo-self branch May 30, 2017 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind:refactor topic:stdlib
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@makenowjust @bcardiff @jhass