Codegen: fixed #4470, to work a return in ensure block #4478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes to work fine an explicit return in body block and ensure block.
Below example is now working:
def foo
return 1
ensure
return 2
end
foo # => 2
NOTE: Why foo returns 2, not 1? -- Because current crystal respects explicit return in ensure block:
def foo
1
ensure
return 2
end
foo # => 2
So, this follows it. It is same as Ruby.
|
LGTM |
|
This is really amazing. I love seeing PRs like this to the compiler ❤️ |
|
@makenowjust while the discussion in #4470 is still evolving, would you mind adding some comments for the logic behind |
|
I'm still in favor of #4486. It's a good thing that there is no hard feelings between both of your PRs 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to work fine an explicit return in body block and ensure block.
Below example is now working:
NOTE: Why
fooreturns2, not1? -- Because current crystal respects explicit return in ensure block:So, this follows it. It is same as Ruby.