JSON metadata #2804
Merged
JSON metadata #2804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kwpolska
reviewed
May 29, 2017
| @@ -1053,6 +1053,16 @@ def _get_metadata_from_file(meta_data): | |||
| meta = toml.load('\n'.join(meta_data[1:idx])) | |||
| return meta | |||
|
|
|||
| # If 1st line is '{', then it's JSON metadata | |||
There was a problem hiding this comment.
ipynb files also start with {. This might need extra handling in some cases (are we likely to reach this function with 1-file ipynb files that have Nikola-specific metadata already?)
There was a problem hiding this comment.
I don't know, really, but I can try to see :-)
|
Note: This feature was withdrawn in commit 2623322. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Naive JSON metadata support (Issue #2801)