Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cernlib: init at 2006 #26179

Merged
merged 1 commit into from
May 29, 2017
Merged

cernlib: init at 2006 #26179

merged 1 commit into from
May 29, 2017

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented May 28, 2017

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

sha256 = "0awla1rl96z82br7slcmg8ks1d2a7slk6dj79ywb871j2ksi3fky";
};

buildInputs = with xorg; [ gfortran gnumake imake makedepend motif libX11 libXft libXt ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gfortran, gnumake, imake and makedepend probably belong to nativeBuildInputs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also link to gfortran libraries.

I don't understand how cross-compilation works in nixpkgs. How for gmake parameter we will get a derivation with host-compatible "make" and for motif we will get the target-compatible libraries.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ericson2314 knows. I just obtain my knowledge from other packages.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's a compiler you want it to be the native one. Eventually the libs will hopefully be separated out, but for now that should work (it certainly will work with non-cross).

GNU Make should be a build-time dep because it runs on the build platform (host -> build, so -1), gfortran likewise because that and because it targets our host platform (target -> host, also -1). Normal run-time deps run on the run are host platform (host -> host, so 0).

@Mic92 Mic92 merged commit b34f336 into NixOS:master May 29, 2017
@veprbl veprbl deleted the cernlib branch December 1, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants