guetzli: init at 1.0.1 #26595
Merged
guetzli: init at 1.0.1 #26595
+31
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pSub
requested changes
Jun 15, 2017
| sha256 = "1wy9wfvyradp0aigfv8yijvj0dgb5kpq2yf2xki15f605jc1r5dm"; | ||
| fetchSubmodules = true; | ||
| }; | ||
| buildInputs = [ libpng pkgconfig ]; |
| { stdenv, libpng, fetchgit, pkgconfig }: | ||
| stdenv.mkDerivation { | ||
| name = "guetzli-1.0.1"; | ||
| src = fetchgit { |
There was a problem hiding this comment.
Please use fetchFromGitHub like so, if it is possible to get rid of fetchSubmodules = true:
src = fetchFromGitHub { owner = "google"; repo = "guetzli"; rev = "v${version}" sha256 = "…"; }
To be able to do that, you have to declare version separately and make the attribute set recursive.
|
@pSub done |
0xABAB
approved these changes
Jul 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
It would be nice to have guetzli inside nixpkgs
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"does not apply./result/bin/)