Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

programs.zsh.syntaxHighlighting: Fix default value for patterns #26380

Merged

Conversation

danielfullmer
Copy link
Contributor

Motivation for this change

Commit 0925f79 changes programs.zsh.syntaxHighlighting.patterns to use attrsets instead of lists of lists. However, the default value was not changed to match the new schema. Building a configuration which uses the default value currently results in an error.

@Ma27 @Mic92

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@danielfullmer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Ma27 and @WilliButz to be potential reviewers.

@joachifm joachifm merged commit 32f066d into NixOS:master Jun 4, 2017
@joachifm
Copy link
Contributor

joachifm commented Jun 4, 2017

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants