Tools cleanup rote #26388
Merged
Tools cleanup rote #26388
+206
−235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Ericson2314, thanks for your PR! By analyzing the history of the files in this pull request, we identified @peti, @vcunat and @dguibert to be potential reviewers. |
Ericson2314
added
the
6.topic: cross-compilation
No hashes of any sort should be changed
Host everywhere would be guaranteed to preserve the old semantics, but in a few places it doesn't matter in practice, target is used instead for clarity.
Ericson2314
force-pushed
the
tools-cleanup-rote
branch
from
5e1da07 to
35ed21d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Rote prerequisite of #26007. That PR is pretty big, so good to sieve out this noise for reviewers' sake.
Things done
Compared cross hashes. None, native or cross, should be changed.
Thanks to @Dridus for doing much of this.