Skip to content

pythonPackages.powerline: 2.5.2 -> 2.6 #26391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2017
Merged

Conversation

ss1h2a3tw
Copy link
Contributor

@ss1h2a3tw ss1h2a3tw commented Jun 5, 2017

Motivation for this change

Update powerline to the latest version.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@mention-bot
Copy link

@ss1h2a3tw, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer.

@ss1h2a3tw ss1h2a3tw changed the title powerline: 2.5.2 -> 2.6 pythonPackages.powerline: 2.5.2 -> 2.6 Jun 5, 2017
@FRidh
Copy link
Member

FRidh commented Jun 5, 2017

Can you move this expression to a new file as described in the header of the current file.

@ss1h2a3tw ss1h2a3tw force-pushed the powerline branch 3 times, most recently from cc811fe to 8beeca3 Compare June 6, 2017 10:38

Verified

This commit was signed with the committer’s verified signature.
edwtjo Edward Tjörnhammar
@ss1h2a3tw
Copy link
Contributor Author

@FRidh I'm still new to nix. I can't figure out why this can't build on test3 on travis-ci. Can you take a look at this?

@Mic92 Mic92 merged commit b9c2593 into NixOS:master Jun 10, 2017
@Mic92
Copy link
Member

Mic92 commented Jun 10, 2017

The travis failure is unrelated to your package.

@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants