BDB Global Patches #1646
Merged
BDB Global Patches #1646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge from RO master
Closed
|
This seems reasonable. @PhineasFreak would it be more efficient to have this patch only run if BDB is installed? Or would we not expect a performance difference, searching every part for these modules? |
|
This should definitely be set as :NEEDS[BluedogDB] as it only needs to run
if that is installed.
…On May 31, 2017 8:13 AM, "stratochief66" ***@***.***> wrote:
This seems reasonable.
@PhineasFreak <https://github.com/phineasfreak> would it be more
efficient to have this patch only run if BDB is installed? Or would we not
expect a performance difference, searching every part for these modules?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1646 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ASjbf3s3u6ZVKytcP-rjfmUvqanqmx-Uks5r_WdmgaJpZM4NoEZI>
.
|
|
@pap1723 @stratochief66 yes, an additional check to see if BDB is both easy to implement and needed (better to skip patching and apply it only when BDB is installed than checking all available parts). |
Added NEEDS:[BluedogDB], as suggested, so the patch only runs if the Bluedog mod is actually installed.
|
Added the :NEEDS criterion, as suggested! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a global config to remove Bluedog Design Bureau part modules that would conflict with RO mods - specifically engine reliability and cryogenic fuel boiloff.