Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wakatime: 7.0.4 -> 8.0.2 #26133

Closed
wants to merge 2 commits into from
Closed

wakatime: 7.0.4 -> 8.0.2 #26133

wants to merge 2 commits into from

Conversation

yurrriq
Copy link
Member

@yurrriq yurrriq commented May 26, 2017 •
edited

Motivation for this change

Upgrade to latest version and switch from buildPythonPackage to buildPythonApplication.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@yurrriq
wakatime: 7.0.4 -> 8.0.2
457eac6 
buildPythonPackage -> buildPythonApplication
@mention-bot
Copy link

@yurrriq, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Mic92 and @nckx to be potential reviewers.

@fpletz
Copy link
Member

fpletz commented May 27, 2017

Acoording to travis, the hash seems to be wrong: https://travis-ci.org/NixOS/nixpkgs/jobs/236475922#L1520

@yurrriq
Copy link
Member Author

yurrriq commented May 27, 2017

This happened to me once before. It works on my system. Is it possible there's something wrong with it?

@yurrriq
Copy link
Member Author

yurrriq commented Jun 13, 2017

Can someone sort out the hash issues?

@joachifm
Copy link
Contributor

@yurrriq How are you generating the hash?

@yurrriq
Copy link
Member Author

yurrriq commented Jun 15, 2017

nix-build -A wakatime and copying from where it says "has hash ... but expected ..."

@orivej orivej changed the title wakatime: 7.0.4 -> 8.0.2 wakatime: 7.0.4 -> 10.0.1 Nov 11, 2017
@orivej orivej changed the title wakatime: 7.0.4 -> 10.0.1 wakatime: 7.0.4 -> 8.0.2 Nov 11, 2017
@orivej orivej closed this in 1acb901 Nov 11, 2017
@yurrriq
Copy link
Member Author

yurrriq commented Nov 13, 2017

Thanks, @orivej!

@yurrriq yurrriq deleted the update/pkgs/tools/misc/wakatime branch November 13, 2017 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@yurrriq @mention-bot @fpletz @joachifm @pSub @GrahamcOfBorg