Fixed meteor Future is not defined error #26127
Conversation
|
cc maintainer @cstrahan |
|
Is this an upstream problem or specific to Nixpkgs somehow? Looks okay to me but would like to understand whether the patch is appropriate. |
|
I think something changed upstream so that |
|
@gabesoft do you happen to know how it works on other distros? Is future loaded implicitly there? I'm curious to know what about our packaging makes it necessary to import it explicitly? |
|
I don't think it's loaded on other distros either because meteor likes to bring everything that it needs during installation. I'll try it on a Mac just to be sure |
|
Actually this package can't be installed on a Mac |
|
@gabesoft Thanks! This should be fine. (Ideally we'd package meteor "the right way", but its design makes that nearly impossible.) |
Motivation for this change
When starting meteor 1.4.2.3 or latest after installing the meteor package the error below occurs. This PR fixes this error.
/nix/store/lczw40pq0qgqz4knh1z6xs1qfa7gi7cr-meteor-1.4.2.3/packages/meteor-tool/.1.4.2_3.17tso1e++os.linux.x86_64+web.browser+web.cordova/mt-os.linux.x86_64/dev_bundle/lib/node_modules/meteor-promise/promise_server.js:190
throw error;
^
ReferenceError: Future is not defined
at spawnSync (/tools/cli/main.js:540:1)
at patchelf (/tools/cli/main.js:561:1)
at springboard (/tools/cli/main.js:569:3)
at /tools/cli/main.js:1166:3
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)