Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages.core_bench: init at 113.33.03 #26126

Merged
merged 1 commit into from
Jun 15, 2017

Conversation

pmahoney
Copy link
Contributor

Motivation for this change

Adding core_bench library (used in Real World OCaml)

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@pmahoney, thanks for your PR! By analyzing the history of the files in this pull request, we identified @aske, @vbgl and @sternenseemann to be potential reviewers.

@Mic92
Copy link
Member

Mic92 commented Jun 15, 2017

Thanks!

@Mic92 Mic92 merged commit a3539d0 into NixOS:master Jun 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants