Skip to content

docker tools: fix pull image function #26131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2017
Merged

docker tools: fix pull image function #26131

merged 1 commit into from
May 27, 2017
+56 −119

Conversation

matejc
Copy link
Contributor

@matejc matejc commented May 26, 2017

Motivation for this change
  • current dockerTools.pullImage outputs 404 no matter what image you gave it even before it starts to download layers (as far as I can see v1 docker registry api is deprecated)
  • current dockerTools.pullImage does not support "/" in the imageName
Things done

Mentioned issues are resolved.

And yes, I do use qemu for starting docker daemon and downloading the image with it, it is the most reliable option (and it works without kvm enabled system, altho a bit slow) and I know that it is not ideal, but if someone wants to make it better, use something like https://pypi.python.org/pypi/python-dxf and reverse engineer the json file(s) needed

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@mention-bot
Copy link

@matejc, thanks for your PR! By analyzing the history of the files in this pull request, we identified @lethalman, @0arthur and @Profpatsch to be potential reviewers.

@matejc matejc requested a review from offlinehacker May 26, 2017 16:40
@matejc matejc force-pushed the pkgs/build-support/docker/pull branch from 26b58a2 to 8d3cb0a Compare May 26, 2017 16:49
@copumpkin
Copy link
Member

cc @jammerful who was also looking at this problem. The KVM thing isn't ideal as you say, but this is certainly better than just failing all the time 😄

@matejc
Copy link
Contributor Author

matejc commented May 26, 2017

yeah and it is still fast, for a virtual machine

@offlinehacker
Copy link
Contributor

Until one comes up with his magic pull python/go script, this is most compatible solution to do pulls, I'll meet it.

@offlinehacker offlinehacker merged commit 112f522 into NixOS:master May 27, 2017
@jtojnar jtojnar mentioned this pull request Jul 18, 2017
Merged
8 tasks
@lo1tuma lo1tuma mentioned this pull request Jul 25, 2017
Closed
@danbst
Copy link
Contributor

danbst commented Oct 20, 2017

Another downside of this PR - private registry (like Amazon ECR) auth was lost.

@copumpkin
Copy link
Member

@danbst wasn't someone using a tool from red hat to replace the image pulling functionality? I can't find it now but I swear I saw it

@danbst
Copy link
Contributor

danbst commented Oct 23, 2017

@copumpkin skopeo thing was reverted a month ago, because it breaks mesos or so, so version from this PR is what we have

@danbst
Copy link
Contributor

danbst commented Oct 23, 2017

do you think, I should open a new issue?

@copumpkin
Copy link
Member

Yeah, that seems like the right approach longer term anyway...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@offlinehacker offlinehacker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@matejc @mention-bot @copumpkin @offlinehacker @danbst