lynx: Fix SSL, widec support #26134
Merged
lynx: Fix SSL, widec support #26134
+4
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dtzWill, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @nckx and @peterhoeg to be potential reviewers. |
|
All tests pass! 👍 |
peterhoeg
reviewed
May 27, 2017
|
|
||
| buildInputs = [ ncurses gzip ]; | ||
| buildInputs = [ ncurses gzip ] ++ stdenv.lib.optionals sslSupport [ openssl.dev pkgconfig ]; |
There was a problem hiding this comment.
Please put pkgconfig into nativeBuildInputs instead.
There was a problem hiding this comment.
Eep, of course. Will fix thanks!
lynx wants both the "include" and "lib/lib*.so" paths to be children of the path given to "--with-ssl", which is not provided by any of the current openssl outputs. To fix lynx so it supports SSL (and https URLs), let it use pkgconfig to figure out where openssl's bits are.
dtzWill
changed the title
|
Also fixing lack of widec support. |
|
Thanks @dtzWill |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lynx wants both the "include" and "lib/lib*.so" paths
to be children of the path given to "--with-ssl",
which is not provided by any of the current openssl outputs.
To fix lynx so it supports SSL (and https URLs),
let it use pkgconfig to figure out where openssl's bits are.
Motivation for this change
nix-built "lynx" doesn't support HTTPS (even when configured to use openSSL, which is the default).
nix-built "lynx" also doesn't handle wide characters currently (unless performing a cross build), so I've changed this to be always enabled instead.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)