Updates Yakuake to version 3.0.3 and exposes the .desktop #26063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bkchr, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ttuegel, @urkud and @kirelagin to be potential reviewers. |
|
I made a mistake. I just checked that the file is in the autostart directory, but it does not work :( I have an idea (need to extend the kde wrapper), sorry for the inconvenience... This pull request does not break anything, just the autostart does not work. You could either revert the commit or I create a new pull request. Sorry again! |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I wanted to autostart Yakuake with makeAutostartItem, but that requires the .desktop file. By adding the .desktop as target you can create an autostart entry with:
(pkgs.makeAutostartItem { name = "yakuake"; package = yakuake; srcPrefix = "org.kde."; });
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)