Skip to content

ipfs: 0.4.6 -> 0.4.9 #26064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2017
Merged

ipfs: 0.4.6 -> 0.4.9 #26064

merged 1 commit into from
May 24, 2017

Conversation

mateon1
Copy link
Contributor

@mateon1 mateon1 commented May 24, 2017

Motivation for this change

IPFS was updated, this version fixes directory sharding, adds an experimental filestore implementation, and contains many bug fixes, and more.
Issue #24704 should not happen with this PR, as I updated fetchgx to use NIX_SSL_CERT_FILE, but please test this independently, as I couldn't reproduce this issue last time (#24523).

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@mention-bot
Copy link

@mateon1, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kamilchm, @matthiasbeyer and @fpletz to be potential reviewers.

@matthiasbeyer
Copy link
Contributor

matthiasbeyer commented May 24, 2017

Nice! Please note that I rolled back the patch from 0.4.6 -> 0.4.8 because it broke my ipfs installation (I'm on unstable) - if this breaks my installation I will roll back this patch as well, but I'd love to get a working update!

@mateon1
Copy link
Contributor Author

mateon1 commented May 24, 2017

@matthiasbeyer No problem, it seems that linux builds on travis succeeded, so I think the NIX_SSL_CERT_FILE fixed it. Also, this PR was tested with sandboxing, while the last one was not.

Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs fine here. Thanks! 👍

@fpletz
Copy link
Member

fpletz commented May 24, 2017

The travis-ci job for darwin is still building go and will probably time out anyway. Let's merge. :)

@fpletz fpletz merged commit 601d8c3 into NixOS:master May 24, 2017
@mateon1 mateon1 deleted the pr/update-ipfs branch May 24, 2017 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants