nss-pam-ldapd: 0.8.13 -> 0.9.7 #26070
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@montag451, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rickynils, @nckx and @dezgeg to be potential reviewers. |
|
Do you know if the NixOS module still works after this update? |
fpletz
added
the
8.has: package (update)
|
@fpletz You are right, I will check. By the way, it could be great if we had a test for this kind of things. If I have time, I will write one. |
|
We are using this module on a machine. I'll try to test this in the next few days. |
7 tasks
fpletz
approved these changes
May 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The version in nixpkgs is very old (> 3 years). The new version has seen a lot of bug fixes and support new functionalities (e.g ppolicy)
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)