Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qt5ct: 0.32 -> 0.33 #26473

Merged
merged 1 commit into from
Jun 10, 2017
Merged

qt5ct: 0.32 -> 0.33 #26473

merged 1 commit into from
Jun 10, 2017

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Jun 8, 2017

Motivation for this change

Update to new version.

Changelog:

  • fixed build without dbus support
  • fixed Qt 5.6 support
  • updated Hebrew translation
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Jun 8, 2017

Can we set this variable by default?

https://dl.thalheim.io/ExksHF1VhC7YrRHH1X7U1Q/2017-06-08.vkuux.png

(the error message comes on startup).

@romildo
Copy link
Contributor Author

romildo commented Jun 8, 2017

From man configuration.nix we have:

       programs.qt5ct.enable
           Whether to enable the Qt5 Configuration Tool (qt5ct), a program
           that allows users to configure Qt5 settings (theme, font, icons,
           etc.) under desktop environments or window manager without Qt
           integration. Official home page: https://sourceforge.net/projects/
           qt5ct/

           Type: boolean

           Default: false

           Declared by:
               <nixpkgs/nixos/modules/programs/qt5ct.nix>

It is enough to set programs.qt5ct.enable in order to have the environment variable QT_QPA_PLATFORMTHEME set to "qt5ct".

See

nixpkgs/nixos/modules/programs/qt5ct.nix

Line 28 in eedc0f0

environment.variables.QT_QPA_PLATFORMTHEME = "qt5ct";
.

It was introduced in PR #23333.

@Mic92
Copy link
Member

Mic92 commented Jun 10, 2017

Thanks!

@Mic92 Mic92 merged commit 86de155 into NixOS:master Jun 10, 2017
@romildo romildo deleted the upd.qt5ct branch December 5, 2017 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romildo @Mic92