Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buck: build buckd as well #26479

Merged
merged 1 commit into from
Jun 9, 2017
Merged

buck: build buckd as well #26479

merged 1 commit into from
Jun 9, 2017

Conversation

jgertm
Copy link
Contributor

@jgertm jgertm commented Jun 8, 2017

Motivation for this change

buck tries to launch buckd to run in the background. While not neccessary, it
does speed up builds.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

buck tries to launch buckd to run in the background. While not neccessary, it
does speed up builds.
@mention-bot
Copy link

@jgertm, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Mic92 to be a potential reviewer.

@Mic92 Mic92 merged commit fdf43dd into NixOS:master Jun 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants