csound: add jack and other dependencies, update version #26217
Merged
+21
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds extra bells and whistles: - jack - ladspa - fluidsynth - fltk (for the virtual keyboard) - curl - gettext The most important one is jack but I added other dependencies which seemed sensible and were mentioned by the configure script.
|
@rvl, thanks for your PR! By analyzing the history of the files in this pull request, we identified @MarcWeber, @hlolli and @wkennington to be potential reviewers. |
|
For some reason, mentionbot hasn't said anything, so I'm notifying csound package maintainer @MarcWeber and @hlolli. |
|
looks good, jack is important here. After this merge not many optional dependencies are left out, maybe Faust and PerryCook's STK plugins. Thanks for adding this, hope someone merges this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Needed to have jack output in csound, and while I was in there I saw some other dependencies which could and should be enabled.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/) -- onlycsound