pythonPackages.future: 0.15.2 -> 0.16.0 #26220
Conversation
|
@erictapen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer. |
|
Can you move this expression to
Why? |
Will edit this asap. Missed that policy.
I felt like |
erictapen
force-pushed
the
python-future-bump
branch
from
9bd4a1a
to
eedc234
Compare
|
@erictapen with fetchPypi we can update the version and hash automatically (see maintainers/scripts/update-python-libraries) |
erictapen
force-pushed
the
python-future-bump
branch
from
eedc234
to
23fa7ec
Compare
|
That sounds reasonable! Moved the expression to Please note, that this is my first contribution besides a simple version bump. I do not really understand what I've done, I just changed things until my package compiled (and worked). |
There was a problem hiding this comment.
Please note, that this is my first contribution besides a simple version bump. I do not really understand what I've done, I just changed things until my package compiled (and worked).
You've made a good start. Just these two edits and then it should be ok to go in. Before, we called the function buildPythonPackage with a set of arguments directly in python-packages.nix. Now, we moved that expression to a separate file. That file is a function, returning our derivation. So, we call a function with a set of arguments and that function calls buildPythonPackage with a set of arguments.
| @@ -0,0 +1,39 @@ | |||
| { lib | |||
| , pkgs | |||
There was a problem hiding this comment.
don't pass in the whole package set, instead, use individual packages
| sha256 = "1nzy1k4m9966sikp0qka7lirh8sqrsyainyf8rk97db7nwdfv773"; | ||
| }; | ||
|
|
||
| propagatedBuildInputs = lib.optionals isPy26 (with pkgs.pythonPackages; [ importlib argparse ]); |
There was a problem hiding this comment.
We are not going to use the package set, but we're going to pass in the individual requirements. Therefore, in the top, you can add the parameters importlib and argparse and remove here with pkgs.pythonPackages;
Also moved the expression from python-packages.nix to ./pkgs/development/python-modules/future/default.nix due to discussion in NixOS#26220 Used fetchPypi insted of fetchurl.
erictapen
force-pushed
the
python-future-bump
branch
from
23fa7ec
to
e6b65c0
Compare
|
Thanks alot. Did you mean this? |
|
Yep! cc maintainer @prikhi |
Motivation for this change
Needed a newer version for another package.
Things done
Bumped version and used fetchFromGitHub insted of fetchurl.
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)