MBS-9342: Fix imports with DBD::Pg 3.6.0 #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default setting, -1, should work the same for us, and the documentation strongly recommends this default. The difference is it respects the client_encoding, but we don't touch that, meaning it defaults to the database encoding instead, which is utf8. If it wasn't, we'd have obvious other problems.
DBD::Pg 3.6.0 fixed their UTF8 flag handling with respect to the pg_(get|put)copydata methods, and the effect is that we now have to decode our strings before passing them into those functions. This change also works with DBD::Pg 3.5.3. The way they changed the UTF8 handling is a bit hard to follow since it deals with Perl internals, but it must have only worked accidentally before, if the behavior we were relying on wasn't intended.
ReplicationSetup.sql is already loaded by create_test_db.sh.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DBD::Pg 3.6.0 fixed their UTF8 flag handling with respect to the pg_(get|put)copydata methods, and the effect is that we now have to decode our strings before passing them into those functions.
This change also works with DBD::Pg 3.5.3. The way they changed the UTF8 handling is a bit hard to follow since it deals with Perl internals, but it must have only worked accidentally before, if the behavior we were relying on wasn't intended.