mcrcon: init at 0.0.5 #26215
mcrcon: init at 0.0.5 #26215
Conversation
|
@dermetfan, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zimbatm, @zraexy and @vcunat to be potential reviewers. |
| buildInputs = [ gcc ]; | ||
|
|
||
| buildPhase = '' | ||
| gcc mcrcon.c -o mcrcon |
There was a problem hiding this comment.
$CC mcrcon.c -o mcrcon
might be more portable.
|
|
||
| installPhase = '' | ||
| mkdir -p $out/bin | ||
| install -m 755 mcrcon $out/bin |
There was a problem hiding this comment.
installPhase = ''
install -D -m755 mcrcon $out/bin/mcron
'';
| sha256 = "1pwr1cjldjy8bxqpp7w03nvdpw8l4vqfnk6w6b3mf0qpap1k700z"; | ||
| }; | ||
|
|
||
| buildInputs = [ gcc ]; |
There was a problem hiding this comment.
are you sure there is a hard dependency on gcc? If not you can just remove this line and use the command as shown above.
| install -m 755 mcrcon $out/bin | ||
| ''; | ||
|
|
||
| phases = "unpackPhase buildPhase installPhase fixupPhase"; |
There was a problem hiding this comment.
These are all default phases. You can remove this.
There was a problem hiding this comment.
Thanks for the review! I hoped excluding some could speed up the build. Not a good practice?
There was a problem hiding this comment.
@dermetfan disabling problematic phases as necessary is more robust, generally.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)