Add isStorePath tests
#26223
Merged
Add isStorePath tests
#26223
+40
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Profpatsch, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @zimbatm and @MarcWeber to be potential reviewers. |
zimbatm
reviewed
May 30, 2017
| in { | ||
| storePath = isStorePath goodPath; | ||
| storePathAppendix = isStorePath | ||
| "${goodPath}/bin/python"; |
There was a problem hiding this comment.
I wonder. We could change the semantics of the function. @edolstra would that make sense?
In any case, it’s nice that this test case documents the current semantics.
There was a problem hiding this comment.
Agreed, without the tests we wouldn't be having this conversation.
zimbatm
reviewed
May 30, 2017
| storePath = isStorePath goodPath; | ||
| storePathAppendix = isStorePath | ||
| "${goodPath}/bin/python"; | ||
| nonAbsolute = isStorePath (concatStrings (tail (stringToCharacters goodPath))); |
There was a problem hiding this comment.
maybe add otherPath = isStorePath "/something/else"?
zimbatm
approved these changes
May 30, 2017
|
I wonder why it includes the first commit again, yes. Maybe the commit ID changed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests cc @zimbatm