txaio: 2.7.1 fixes #26224
Merged
txaio: 2.7.1 fixes #26224
+12
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nand0p
commented
May 30, 2017
nand0p
commented
- uses fetchpypi
- fixes broken test
- tested nixos python 27/34
- uses fetchpypi - fixes broken test - tested nixos python 27/34
FRidh
reviewed
May 30, 2017
| inherit pname version; | ||
| sha256 = "1lmllmjjsqzl3w4faq2qhlgkaqn1yn1m7d99k822ib7qgz18bsly"; | ||
| }; | ||
|
|
||
| buildInputs = [ pytest mock ]; |
FRidh
reviewed
May 30, 2017
| propagatedBuildInputs = [ six twisted ]; | ||
|
|
||
| patchPhase = '' |
There was a problem hiding this comment.
if you override the patchPhase, you remove the test runner. Use (Somehow I keep reading postPatch here instead because you patch code.checkPhase instead of patchPhase...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.