pandas: Fix build on darwin #26221
Merged
pandas: Fix build on darwin #26221
+14
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@knedlsepp, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh and @teh to be potential reviewers. |
knedlsepp
force-pushed
the
fix-pandas-darwin-build
branch
from
7955010 to
eb2994a
Compare
Since the commands "locale", "pbpaste" and "pbcopy" are not in nixpkgs, as they are impure darwin dependencies, we currently cannot get the clipboard and locale functionality to work properly. We disable the tests "test_locale" and "test_clipboard" on darwin, so we get a mostly working pandas. Additionally to disabling the test via py.test, we also need to provide fake pbpaste/pbcopy commands, so py.test won't fail during the collection phase. This closes NixOS#25417 and closes NixOS#11623.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fix the darwin build of pandas.
Since the commands "locale", "pbpaste" and "pbcopy" are not in nixpkgs,
as they are impure darwin dependencies, we currently cannot get the
clipboard and locale functionality to work properly. We disable the
tests "test_locale" and "test_clipboard" on darwin, so we get a mostly
working pandas. Additionally to disabling the test via py.test, we also
need to provide fake pbpaste/pbcopy commands, so py.test won't fail
during the collection phase.
This closes #25417 and closes #11623.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)