treq: 17.3.1 fixes #26222
treq: 17.3.1 fixes #26222
Conversation
nand0p
commented
May 30, 2017
nand0p
commented
- enables and fixes tests
- makes docs properly
- tested nixos python 27/34
| ${coreutils}/bin/mkdir -pv treq | ||
| ${coreutils}/bin/echo "${version}" | ${coreutils}/bin/tee treq/_version | ||
| cd docs && ${gnumake}/bin/make html && cd .. | ||
| tox -e docs |
There was a problem hiding this comment.
makes documentation available in $out. however, it is erroneously writing out to /tmp at the moment.
There was a problem hiding this comment.
do always document why you run commands like these because its not obvious at all what it does.
| @@ -33,13 +33,12 @@ buildPythonPackage rec { | |||
| trial treq | |||
| ''; | |||
|
|
|||
| doCheck = false; | |||
| # Failure: twisted.web._newclient.RequestTransmissionFailed: [<twisted.python.failure.Failure OpenSSL.SSL.Error: [('SSL routines', 'ssl3_get_server_certificate', 'certificate verify failed')]>] | |||
| patchPhase = '' | |||
There was a problem hiding this comment.
Please always use postPatch when adding additional patching. That way, one can still pass in patches.
nand0p
force-pushed
the
treq-fixes
branch
4 times, most recently
from
0378062 to
affd5a3
Compare
|
@FRidh ready_for_review |
| cd docs && ${gnumake}/bin/make html && cd .. | ||
| # build documentation and install in $out | ||
| tox -e docs | ||
| cp -rv docs $out |
There was a problem hiding this comment.
Should they not go in a specific folder? Note that with Python packages we typically do not bother with the docs.
- enables and fixes tests - makes docs properly - used fetchpypi - tested nixos python 27/34
|
@FRidh updated to correctly write out documentation to |
|
@nand0p its just that its the wrong destination. Documentation likely goes somewhere in |
|
@FRidh im seeing other python mods like |
