Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rssguard: init at 3.4.0 #26408

Merged
merged 2 commits into from
Jun 6, 2017
Merged

rssguard: init at 3.4.0 #26408

merged 2 commits into from
Jun 6, 2017

Conversation

jluttine
Copy link
Member

@jluttine jluttine commented Jun 5, 2017

Motivation for this change

RSS Guard is a simple, light and easy-to-use RSS/ATOM feed aggregator developed using Qt framework and with online feed synchronization support for ownCloud/Nextcloud.

Please check my commit and feel free to comment. This is my first contribution of a real application so I may be doing something wrong. So thanks for any feedback!

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@@ -15162,6 +15162,9 @@ with pkgs;

polybar = callPackage ../applications/misc/polybar { };

rssguard = libsForQt5.callPackage ../applications/networking/feedreaders/rssguard { };
#rssguard = libsForQt5.callPackage ../applications/networking/newsreaders/rssguard { };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this leftover comment. :)

@Mic92 Mic92 merged commit 17e9420 into NixOS:master Jun 6, 2017
@jluttine
Copy link
Member Author

jluttine commented Jun 6, 2017

@Mic92 Thanks for making the fixes. May I ask, what is the purpose of wrapGAppsHook here? I thought wrapGAppsHook was related to GTK/GNOME apps but this is Qt app, so I'm probably misunderstanding something.

@jluttine jluttine deleted the add-rssguard branch June 7, 2017 09:49
@Mic92
Copy link
Member

Mic92 commented Jun 10, 2017

Qt applications will also use gtk3 file dialogs if the environment is set up this way. This leads to crashes of the application if wrapGAppsHook is not set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants