Fix cmake soft errors due to failing creation of links on windows #2645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkaiser
reviewed
May 21, 2017
| @@ -0,0 +1 @@ | |||
| mklink /J "%1" "%2" | |||
There was a problem hiding this comment.
This file misses copyright and license
Naios
force-pushed
the
symbolic_link_error_pr
branch
2 times, most recently
from
296d71c
to
735f36f
Compare
hkaiser
requested changes
May 21, 2017
There was a problem hiding this comment.
This looks good to me, thanks a lot. This has actually annoyed me to no end ever since ;)
The only thing I'd ask you to change is the name of the macro. For cmake macros we have so far used the gnu_naming_convention instead of CamelCaseNames.
I know it's a minor issue - may I ask you to change that anyways?
* Prevents errors when generating the documentation on windows since cmake doesn't provide the `create_symlink` there. * We use cmd under windows to create links instead
Naios
force-pushed
the
symbolic_link_error_pr
branch
from
735f36f
to
0bb983f
Compare
|
@hkaiser sure, I adapted the PR so it conforms with the current cmake macro naming conventions |
hkaiser
approved these changes
May 21, 2017
Perfect, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use cmd under windows to create links
on windows since cmake doesn't provide the
create_symlinkthere.See the following screenshot:
Further reference of
create_symlink <old> <new>: https://cmake.org/cmake/help/v3.2/manual/cmake.1.html#unix-specific-command-line-tools